Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Golang 1.13.9 #89275

Merged
merged 3 commits into from
Mar 24, 2020
Merged

Update to Golang 1.13.9 #89275

merged 3 commits into from
Mar 24, 2020

Conversation

justaugustus
Copy link
Member

What type of PR is this?
/kind feature cleanup
/area dependency

What this PR does / why we need it:

  • deps: Update to Golang 1.13.9
  • build: Remove kube-cross image building

Accompanying kube-cross bump: kubernetes/release#1200

/assign @BenTheElder @liggitt @cblecker @dims @listx
/milestone v1.18
cc: @kubernetes/release-team @kubernetes/release-engineering
ref: quarterly updates

Does this PR introduce a user-facing change?:

- deps: Update to Golang 1.13.9
- build: Remove kube-cross image building

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes labels Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 20, 2020
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject area/test sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 20, 2020
@justaugustus justaugustus mentioned this pull request Mar 20, 2020
Closed
25 tasks
@justaugustus
Copy link
Member Author

/retest

@justaugustus justaugustus mentioned this pull request Mar 21, 2020
Merged
@justaugustus
Copy link
Member Author

/test pull-kubernetes-typecheck

This was referenced Mar 21, 2020
Merged
Closed
@justaugustus
Copy link
Member Author

(Dropped the staging image commit (2ae4a0ed0e146e435984171cac4dffed415df064) now that the kube-cross:v1.13.9-2 image has been promoted)

@justaugustus
Copy link
Member Author

This PR is currently blocked on tests failing due to bazel.
I've provided details here: #88553 (comment)

@ixdy
Copy link
Member

ixdy commented Mar 23, 2020

An alternative to updating rules_go is ixdy@2a189ad.

justaugustus and others added 2 commits March 23, 2020 17:10
@justaugustus
build: Remove kube-cross image building
32b61ea 
kube-cross image building has moved to k/release/images/build/cross.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus @ixdy
deps: Update to Golang 1.13.9
b6179ac 
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Co-authored-by: Jeff Grafton <jgrafton@google.com>
@justaugustus
Copy link
Member Author

@ixdy -- Thanks so much! I've squashed that in as b6179ac.

@justaugustus
Copy link
Member Author

/retest

@justaugustus
Copy link
Member Author

Looks like most of the tests are starting to pass, so I'm going to apply @ixdy's fix on the 1.14.1 PR (#88638) as well.

@justaugustus
build/dependencies: Remove bazel WORKSPACE go_version check
979e3e0 
When supplying the go_download_sdk instead of updating rules_go, the
go_version is removed, so we shouldn't check for it anymore in
hack/verify-external-dependencies-version.sh.

Without this, pull-kubernetes-verify jobs will fail.

Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus
Copy link
Member Author

Added 979e3e0:

build/dependencies: Remove bazel WORKSPACE go_version check
    
When supplying the go_download_sdk instead of updating rules_go, the
go_version is removed, so we shouldn't check for it anymore in
hack/verify-external-dependencies-version.sh.

Without this, `pull-kubernetes-verify` jobs will fail.

liggitt
liggitt reviewed Mar 24, 2020
View reviewed changes
build/root/WORKSPACE
Comment on lines +55 to +71
# The version of rules_go we're using here is no longer supported, so
# we must manually download a newer version of the go sdk.
go_download_sdk(
name = "go_sdk",
sdks = {
"darwin_amd64": ("go1.13.9.darwin-amd64.tar.gz", "450e59538ed5d3f2b165ba5107530afce6e8e89c6cc5c90a0cbf0a58846ef3b1"),
"freebsd_386": ("go1.13.9.freebsd-386.tar.gz", "6b75a5a46ebbdf06aa5023f2bd0ad7e9e37389125468243368d5795e1c15c9cd"),
"freebsd_amd64": ("go1.13.9.freebsd-amd64.tar.gz", "87716246da52c193226df44031aaf45e45ebfc23e01bdc845311c1b560e76e2b"),
"linux_386": ("go1.13.9.linux-386.tar.gz", "a2744aa2ddc68d888e9f65c2cbe4c8b527b139688ce232ead90dc2961f8d51a8"),
"linux_amd64": ("go1.13.9.linux-amd64.tar.gz", "f4ad8180dd0aaf7d7cda7e2b0a2bf27e84131320896d376549a7d849ecf237d7"),
"linux_arm64": ("go1.13.9.linux-arm64.tar.gz", "b53cb466d7986e5e17a3d4c196bc95df08a35968eced5efd7e128387a246c46e"),
"linux_arm": ("go1.13.9.linux-armv6l.tar.gz", "a3c2941a1fde8692514ece7e2180a0e3ca70609f52756a66bc0ab68c63572361"),
"linux_ppc64le": ("go1.13.9.linux-ppc64le.tar.gz", "90beb01962202f332be0a7c8dad2db3d30242759ba863db3f36c45d241940efc"),
"linux_s390x": ("go1.13.9.linux-s390x.tar.gz", "a40949aaf55912b06df8fda511c33fde3e52d377706bdc095332652c1ad225e3"),
"windows_386": ("go1.13.9.windows-386.zip", "e22406377448f1aea2dd1517327e5ae452d826c0c7624b3511d5af510c57b69a"),
"windows_amd64": ("go1.13.9.windows-amd64.zip", "cf066aabdf4d83c251aaace14b57a35aafffd1fa67d54d907f27fb31e470a135"),
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deep magic from the dawn of time

Copy link
Member

@ixdy ixdy Mar 24, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a little bit of efb21a5 mixed with https://github.com/bazelbuild/rules_go/blob/master/go/private/sdk_list.bzl. :)

@liggitt
Copy link
Member

liggitt commented Mar 24, 2020

go bits look good. I'll take @ixdy's word on the bazel bits from ixdy@2a189ad

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@justaugustus
Copy link
Member Author

Cherry picks opened:

This was referenced Mar 24, 2020
Merged
Merged
Merged
@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce

@justaugustus justaugustus mentioned this pull request Mar 24, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit cadbfd8 into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: v1.18, v1.19 Mar 24, 2020
@justaugustus justaugustus mentioned this pull request Mar 24, 2020
Merged
6 tasks
@seanmalloy seanmalloy mentioned this pull request Apr 1, 2020
Merged
@justaugustus justaugustus mentioned this pull request Jul 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@ixdy ixdy ixdy left review comments

@listx listx Awaiting requested review from listx

@mkumatag mkumatag Awaiting requested review from mkumatag

Assignees

@dims dims

@listx listx

@BenTheElder BenTheElder

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng Issues or PRs related to the Release Engineering subproject area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@justaugustus @ixdy @liggitt @k8s-ci-robot @dims @listx @BenTheElder @cblecker